Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce configurable parameters for ES client node draining #407

Merged

Conversation

A-Kamaee
Copy link
Contributor

@A-Kamaee A-Kamaee commented Apr 29, 2024

Add new configuration options to manage the draining of nodes in the Elasticsearch client

Issue : #404

Description

Add new configuration options to manage the draining of nodes in the Elasticsearch client within the ES-operator project. These settings include the number of retries and the minimum and maximum wait times for retries, enhancing the flexibility and control over the node draining process.

-elasticsearch-client-draining-retry: Sets the number of retries for draining operations.
-elasticsearch-client-draining-min-wait-time: Defines the minimum wait time between retry attempts.
-elasticsearch-client-draining-max-wait-time: Specifies the maximum wait time between retry attempts.

These parameters allow operators to tailor the draining behavior based on specific needs and conditions of their Elasticsearch clusters, ensuring more effective and reliable operations.

Types of Changes

  • Configuration change
  • Refactor/improvements
  • Documentation / non-code

Tasks

List of tasks you will do to complete the PR

  • Add the new configuration parameters
  • Using the new parameters
  • Remove the old default values for parameters
  • Write new tests regarding loading draining configuration from eds
  • Make sure tests pass correctly
  • Test the new version in the local environment (minikube)
  • Remove the TODO regarding parameterizing configurations
  • Update the documentation
  • Add tests to check validation works for newly added configrations
  • Add tests to validate configuration reflect in es-client behaviour

Review

  • Tests
  • Documentation
  • CHANGELOG

@A-Kamaee A-Kamaee force-pushed the node-drain-parametrization-2 branch 3 times, most recently from 45b2041 to a76085e Compare April 29, 2024 08:42
@A-Kamaee A-Kamaee force-pushed the node-drain-parametrization-2 branch from 1e5a727 to 9551481 Compare April 30, 2024 12:38
@A-Kamaee A-Kamaee marked this pull request as ready for review April 30, 2024 12:48
@otrosien
Copy link
Member

otrosien commented May 8, 2024

👍

README.md Outdated Show resolved Hide resolved
@A-Kamaee A-Kamaee force-pushed the node-drain-parametrization-2 branch 3 times, most recently from d4bcfcd to ca4ffaa Compare May 14, 2024 09:14
Abouzar Kamaee added 13 commits May 14, 2024 16:10
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
…handle backward compatibility.

Signed-off-by: Abouzar Kamaee <[email protected]>
Signed-off-by: Abouzar Kamaee <[email protected]>
@A-Kamaee
Copy link
Contributor Author

@otrosien @mikkeloscar

I applied the changes you suggested, it would be nice if you can review and approve this PR. Thanks a lot. 🙏

@mikkeloscar
Copy link
Collaborator

👍

1 similar comment
@A-Kamaee
Copy link
Contributor Author

👍

@A-Kamaee
Copy link
Contributor Author

@otrosien

1 similar comment
@A-Kamaee
Copy link
Contributor Author

@otrosien

@otrosien
Copy link
Member

👍

@otrosien otrosien merged commit 54dc371 into zalando-incubator:master May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants